[Fix] Don't use single-node cluster for databricks_sql_permissions
#4141
+50
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the internal changes in the backend API, it doesn't allow to create non-UC single-node clusters. Until the fix is implemented on the backend, create a cluster for setting permissions consisting of 1 worker. Also, went through the documentation's grammar. Resolves #4140
tanmay-db
approved these changes
Nov 14, 2024
| CustomTags: map[string]string{ | ||
| "ResourceClass": "SingleNode", | ||
| }, | ||
| // TODO: return back after backend fix is rolled out |
There was a problem hiding this comment.
Is there an internal ticket which tracks this?
There was a problem hiding this comment.
I need to ask the product team about Jira...
|
@tanmay-db it looks like the engineering team is actively working on fixing it, so we may not need this change. Let keep it open for a some time although |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Due to the internal changes in the backend API, it doesn't allow to create non-UC single-node clusters. Until the fix is implemented on the backend, create a cluster for setting permissions consisting of 1 worker.
Also, went through the documentation's grammar.
Resolves #4140
Tests
make testrun locallydocs/folderinternal/acceptance